Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps.ffmpeg: Enable runtime CPU detection for AOM to fix ARM64 crashes #238

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

PatTheMav
Copy link
Member

Description

Enables AOM runtime CPU detection on macOS.

Motivation and Context

Runtime CPU detection in AOM has been extended to properly detect ARM64 CPUs and enable NEON features if possible - disabling the runtime detection has been found to lead to crashes when attempting to record using AOM on Apple Silicon Macs.

Fixes obsproject/obs-studio#10226.

How Has This Been Tested?

Tested on macOS 14.3.1 doing AOM recordings with an updated libavcodec.dylib inserted into OBS app bundle.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

Runtime CPU detection in AOM has been extended to properly detect
ARM64 CPUs and enable NEON features if possible - disabling the runtime
detection has been found to lead to crashes when attempting to record
using AOM on Apple Silicon Macs.
Copy link
Member

@RytoEX RytoEX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine.

@RytoEX RytoEX merged commit 9cdd1de into obsproject:master Feb 15, 2024
21 checks passed
@PatTheMav PatTheMav deleted the aom-arm64-fix branch March 16, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[macOS] [30.1 Beta] Starting AOM AV1 output crashes OBS
2 participants